Repository navigation
Translate pointer to data member - #621
Merged
Merged
Conversation
lucic71
marked this pull request as draft
November 16, 2026 17:10
lucic71
marked this pull request as ready for review
November 16, 2026 17:16
nunoplopes
reviewed
Nov 16, 2026
|
|
||
| std::string | ||
| ConverterRefCount::GetFieldOffsetAsString(const clang::FieldDecl *field) { | ||
| return std::format("<{} as Record>::OFFSETS.{}", |
Contributor
There was a problem hiding this comment.
this is super ugly. Should be hidden in a macro
Contributor
|
@copilot resolve the merge conflicts in this pull request |
lucic71
marked this pull request as draft
November 16, 2026 21:28
lucic71
marked this pull request as ready for review
November 16, 2026 21:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Translate pointer to data member as an isize offset into the struct. Also add tests for all pointers to member (data member, function member, inheritance) (#619).
Only data members are translated, function members and inheritance tests are still failing.